bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: base32, base64: Prefer stdckdint to intprops.


From: Bruno Haible
Subject: Re: base32, base64: Prefer stdckdint to intprops.
Date: Wed, 08 May 2024 09:25:20 +0200

Hi Collin,

> I noticed Gnulib changed most of the *_WRAPV to the ckd_* variants at
> some point. Is there a reason that INT_MULTIPLY_OK is still used in
> base32 and base64 or can I apply the following patch?

No particular reason. The patch is OK to push.

> It looks like the module description were missing 'intprops' in the
> depends on these modules too. I guess everyone that used it had it in
> their module list or as a transitive dependency.

Such a blatant module dependency omission should be detectable with
  $ ./gnulib-tool --test --single-configure base32
  $ ./gnulib-tool --test --single-configure base64
With .sh, both fail. With .py, both succeed. Looks like a bug in
gnulib-tool.py: When the 'make' or 'make check' step fails, the entire
command should fail.

Bruno






reply via email to

[Prev in Thread] Current Thread [Next in Thread]