bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

gnulib-tool.py: Quote file names passed to 'patch'.


From: Collin Funk
Subject: gnulib-tool.py: Quote file names passed to 'patch'.
Date: Wed, 1 May 2024 21:34:50 -0700
User-agent: Mozilla Thunderbird

I noticed that the file names when running 'patch' on test-driver
weren't quoted. I guess that would cause problems in practice if you
used spaces in directories, which I have my own opinions on. :)

Since we assume POSIX shells we can just use shlex.quote() to deal
with any theoretical shell injections too [1]. In practice I don't
think that should ever be a problem.

I've applied the attached patch.

[1] https://docs.python.org/3/library/shlex.html#shlex.quote

Collin

Attachment: 0001-gnulib-tool.py-Quote-file-names-passed-to-patch.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]