bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] sys_stat: update comments for S_IRWXUGO, S_IXUGO


From: Paul Eggert
Subject: [PATCH] sys_stat: update comments for S_IRWXUGO, S_IXUGO
Date: Mon, 26 Oct 2020 16:53:13 -0700

* lib/sys_stat.in.h (S_IXUGO, S_IRWXUGO): Update comments.
Perhaps these macros should be removed, as they’re not in either
POSIX or GNU.  They could be moved to stat-macros.h, which would
be cleaner in some sense.
---
 ChangeLog         | 8 ++++++++
 lib/sys_stat.in.h | 4 ++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index bb838bc88..4eb5bcb1d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2020-10-26  Paul Eggert  <eggert@cs.ucla.edu>
+
+       sys_stat: update comments for S_IRWXUGO, S_IXUGO
+       * lib/sys_stat.in.h (S_IXUGO, S_IRWXUGO): Update comments.
+       Perhaps these macros should be removed, as they’re not in either
+       POSIX or GNU.  They could be moved to stat-macros.h, which would
+       be cleaner in some sense.
+
 2020-10-25  Bruno Haible  <bruno@clisp.org>
 
        ssfmalloc tests: Small tweaks.
diff --git a/lib/sys_stat.in.h b/lib/sys_stat.in.h
index 2d1261074..2578b48df 100644
--- a/lib/sys_stat.in.h
+++ b/lib/sys_stat.in.h
@@ -375,11 +375,11 @@ struct stat
 # define S_IRWXO (S_IROTH | S_IWOTH | S_IXOTH)
 #endif
 
-/* S_IXUGO is a common extension to POSIX.  */
+/* Although S_IXUGO and S_IRWXUGO are not specified by POSIX and are
+   not implemented in GNU/Linux, some Gnulib-using apps use the macros.  */
 #if !S_IXUGO
 # define S_IXUGO (S_IXUSR | S_IXGRP | S_IXOTH)
 #endif
-
 #ifndef S_IRWXUGO
 # define S_IRWXUGO (S_IRWXU | S_IRWXG | S_IRWXO)
 #endif
-- 
2.25.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]