bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Port getprogname module to SCO OpenServer


From: Bruno Haible
Subject: Re: Port getprogname module to SCO OpenServer
Date: Sun, 11 Oct 2020 21:18:10 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-189-generic; KDE/5.18.0; x86_64; ; )

Hi Benji,

> > It is better, but there are still (minor) things to tweak.
> Minor things tweaked.
> 
> I'm not sure why I cast getpid to int.
> 
> Including string.h did fix the strrchr warning.
> 
> Now using __SCO_SERVER__ || __sysv5__ for OpenServer6/UnixWare7 and SCO 
> cc/GCC detection.

Thanks.

> Also as far as the indentation goes, it is correct as far as I can tell. 

No, these lines were not indented right:
+           {
+             progname = buf;
+           }

I fixed the indentation and committed the patch in your name.

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]