bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

another stdio patch for UnixWare


From: Tim Rice
Subject: another stdio patch for UnixWare
Date: Thu, 1 Oct 2020 18:33:41 -0700 (PDT)
User-agent: Alpine 2.11 (UW2 23 2013-08-11)

I have attached an additional patch for the stdio parts

2020-09-30  Tim Rice  <tim@multitalents.net>
        * lib/stdio-impl.h: Add support for UnixWare
        * lib/freadahead.c: Use __fpending on UnixWare
        * lib/fflush.c: Update comments for UnixWare
        * lib/fpending.c: Likewise.
        * lib/freadable.c: Likewise.
        * lib/freadptr.c: Likewise.
        * lib/freadseek.c: Likewise.
        * lib/fseterr.c: Likewise.
        * lib/fwritable.c: Likewise.
        * lib/fwriting.c: Likewise.

THe hunk in lib/freadahead.c could potentially be used for other
system that define HAVE__FPENDING (Solaris and others?) but I have
not tested them so limited to UniWare (and OpenServer 6).

With  either of the nap() patches in 
    https://lists.gnu.org/archive/html/bug-gnulib/2020-09/msg00126.html
and the stdio_ext patch in
    https://lists.gnu.org/archive/html/bug-gnulib/2020-09/msg00127.html
and the stdio_ext_m4 patch in
    https://lists.gnu.org/archive/html/bug-gnulib/2020-09/msg00132.html
and the attached patch, I am down to 2 failures in the stdio tests.

I used this from one of Bruno's posts
....
./gnulib-tool --create-testdir --dir=/var/tmp --with-tests \
    --single-configure --avoid=havelib-tests fseterr freadable fwritable \
    fbufmode freading fwriting freadptr freadseek freadahead fpurge fseeko
    ftello fpending fflush 
....

gltests/test-suite.log looks like this.
-----
=====================================
   dummy 0: gltests/test-suite.log
=====================================

# TOTAL: 118
# PASS:  116
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: test-fflush2.sh
=====================

test-fflush2.c:93: assertion 'c == '!'' failed
Abort - core dumped
FAIL test-fflush2.sh (exit status: 134)

FAIL: test-sigaction
====================

test-sigaction.c:69: assertion '(sa.sa_flags & SA_SIGINFO) == 0' failed
test-sigaction.c:69: assertion '(sa.sa_flags & SA_SIGINFO) == 0' failed
[snip 12150 lines]
test-sigaction.c:69: assertion '(sa.sa_flags & SA_SIGINFO) == 0' failed
test-sigaction.c:69: assertion '(sa.sa_flags & SA_SIGINFO) == 0' failed
test-sigaction.c:69: assertion '(sa.sa_flags & SA_SIGINFO) == 0' failed
test-sigaction.c:69: assertion '(sa.sa_flags & SA_SIGINFO) == 0' failed
test-sigaction.c:69: assertion '(sa.sa_flags & SA_SIGINFO) == 0' failed
test-sigaction.c:69: assertion '(sa.sa_flags & SA_SIGINFO) == 0' failed
test-sigaction.c:69: assertion '(sa.sa_flags & SA_SIGINFO) == 0' failed
FAIL test-sigaction (exit status: 139)

-----

Looks like test-fflush2 failure may be an ungetc issue. I'll see if I
can get a Xinuos engineer to fix ungetc/ungetwc

While I was working on this I spotted a mistake in the extended stdio
bits  on UnixWare. __fbufsiz should have been __fbufsize.
I will work on getting a Xinuos engineer to fix this.

And then there is the test-sigaction.c failure. Ah, more debugging to do.

I am looking forward to seeing the patches make it onto the tree.

Thanks for your consideration.

-- 
Tim Rice                                Multitalents
tim@multitalents.net

Attachment: unixware-stdio.patch
Description: unixware-stdio.patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]