Re: [PATCH] getentropy, getrandom: new modules

[Paul Eggert]

On 5/30/20 5:58 AM, Bruno Haible wrote:
> There are several problems with this commit:
>   - It causes a Continuous Integration failure.
>   - It partially overlaps with the crypto/gc-random module.
>   - The ChangeLog entry lists files that were not committed.
>   - It conflicts with the declaration on Solaris 11.3 and newer.
>   - It adds a new header file, <sys/random.h>, but without the usual
>     header file tests in C and C++.

Thanks for fixing most of those problems.

The remaining issue is "partial overlap with crypto/gc-random". To fix that, I
am thinking that getrandom should remove its dependency on crypto/gc-random, and
should simply use "/dev/urandom" for the nonce device without worrying about
whether crypto/gc-random would define NAME_OF_NONCE_DEVICE to "/dev/urandom".
This should work on all current porting targets and should simplify maintenance
by lessening dependencies on the crypto/gc-random module, which pulls in several
other modules that some packages won't want to bother with.