[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gettimeofday: do not use LoadLibrary when built for Windows
|
From: |
Daiki Ueno |
|
Subject: |
Re: [PATCH] gettimeofday: do not use LoadLibrary when built for Windows Store apps |
|
Date: |
Fri, 29 May 2020 07:12:28 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hello,
Bruno Haible <bruno@clisp.org> writes:
> diff --git a/lib/stat-w32.c b/lib/stat-w32.c
> index b9163f5..02ad9ab 100644
> --- a/lib/stat-w32.c
> +++ b/lib/stat-w32.c
> @@ -40,18 +40,20 @@
> #include "pathmax.h"
> #include "verify.h"
>
> +#if !(_WIN32_WINNT >= _WIN32_WINNT_VISTA)
> +
I am totally unfamiliar with Windows code, but this change seems to
break MinGW cross build, because GetFinalPathNameByHandleFunc is defined
only if !(_WIN32_WINNT >= _WIN32_WINNT_VISTA), but referred to from
_gl_convert_FILETIME_to_timespec without the guard:
../../gl/stat-w32.c: In function '_gl_fstat_by_handle':
../../gl/stat-w32.c:259:23: error: 'GetFinalPathNameByHandleFunc' undeclared
(first use in this function); did you mean 'GetFinalPathNameByHandleW'?
259 | || (GetFinalPathNameByHandleFunc != NULL
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| GetFinalPathNameByHandleW
Regards,
--
Daiki Ueno