[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] read-file: add variants that clear internal memory
From: |
Bruno Haible |
Subject: |
Re: [PATCH] read-file: add variants that clear internal memory |
Date: |
Tue, 26 May 2020 20:33:34 +0200 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-177-generic; KDE/5.18.0; x86_64; ; ) |
Hi Daiki,
> > If you agree, I'd like to see two commits:
> > 1. the introduction of the flags and RF_BINARY,
> > 2. the RF_SENSITIVE flag.
> >
> > Do you want me to code the first commit, or do you want to do it?
>
> Sure, that would make things much simpler. I'm attaching a patch along
> these lines.
It would be useful to first concentrate on the first part, the refactoring
that introduces flags and RF_BINARY. This would provide a patch that is easier
to review and does not have the following problems:
- internal_fread_file still exists, although fread_file is a no-op wrapper
around it.
- In tests/test-read-file.c, please terminate the main() function with a
return statement. We assume C99 only in modules that explicitly list 'c99'
as a dependency. If it's trivial to avoid this dependency, let's do it.
- The NEWS file needs an entry.
Bruno
- [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/26
- Re: [PATCH] read-file: add variants that clear internal memory, Bruno Haible, 2020/05/26
- Re: [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/26
- Re: [PATCH] read-file: add variants that clear internal memory,
Bruno Haible <=
- Re: [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/27
- Re: [PATCH] read-file: add variants that clear internal memory, Bruno Haible, 2020/05/27
- Re: [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/27
- Re: [PATCH] read-file: add variants that clear internal memory, Bruno Haible, 2020/05/28
- Re: [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/28
- Re: [PATCH] read-file: add variants that clear internal memory, Bruno Haible, 2020/05/29
- Re: [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/29