Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

[Bruno Haible]

Giulio Benetti wrote:
> > Since you reported a redefinition warning regarding 'gettext_noop',
> > gettext_noop must have been defined as a macro already elsewhere. Where?
> 
> gettext_noop() is defined in environment gettext.h

What do you mean by "environment gettext.h"??

The documentation [1] says
  "Do not install the gettext.h file in public locations. Every package
   that needs it should contain a copy of it on its own."

There should not be a <gettext.h> in public include file directories!

> and in 
> libbytesize/configure.ac they define:
> CFLAGS="${CFLAGS} -DENABLE_NLS"
> ...
> libbytesize should define ENABLE_NLS according to host gettext presence 

This is perfectly OK. It implies that their package won't compile if
gettext() is not contained in libc or GNU gettext was not installed.
But it is NOT the cause of the warning that you are seeing.

> the problem to be fixed is in libbytesize and 
> it's not fixed by the PR I've already open, I need to modify 
> configure.ac to emit ENABLE_NLS according to host gettext presence.

No, libbytesize is OK.

> only once, it's enough to see gettext_noop() redefined, since it's 
> defined in host.

The "host" that you are alluding to is the problem.

Bruno

[1] 
https://www.gnu.org/software/gettext/manual/html_node/lib_002fgettext_002eh.html