[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnulib tests leftovers
From: |
Ralf Wildenhues |
Subject: |
Re: gnulib tests leftovers |
Date: |
Sun, 23 May 2010 10:29:27 +0200 |
User-agent: |
Mutt/1.5.20 (2009-10-28) |
Hi Jim,
* Jim Meyering wrote on Sun, May 23, 2010 at 10:14:30AM CEST:
> That is one of the key points of init.sh: automatically
> isolate tests, so that using generic (not obfuscated out-$$)
> names like 'out' and 'err' works safely, as expected.
Ah, good. I really didn't read the script carefully enough.
> tests/test-pwrite.c appears to be the culprit:
>
> char const *file = "out";
> ...
> fd = open (file, O_CREAT | O_WRONLY, 0600);
Ah, ok. Thanks! In that case, ok to commit this fix?
Cheers,
Ralf
Fix distcheck failure with the pwrite-tests module.
* tests/test-pwrite.c: Use a more unique output file.
Unlink it after testing.
diff --git a/tests/test-pwrite.c b/tests/test-pwrite.c
index 549be10..b953321 100644
--- a/tests/test-pwrite.c
+++ b/tests/test-pwrite.c
@@ -28,11 +28,12 @@ SIGNATURE_CHECK (pwrite, ssize_t, (int, const void *,
size_t, off_t));
#include "macros.h"
#define N (sizeof buf - 1)
+#define BASE "test-pwrite.t"
int
main (void)
{
- char const *file = "out";
+ char const *file = BASE "out";
int fd;
char buf[] = "0123456789";
off_t pos = 2;
@@ -75,5 +76,7 @@ main (void)
ASSERT (close (fd) == 0);
ASSERT (strcmp ("W1W3W5W7W9",buf) == 0);
}
+
+ ASSERT (unlink (file) == 0);
return 0;
}
- gnulib tests leftovers, Ralf Wildenhues, 2010/05/23
- Re: gnulib tests leftovers, Jim Meyering, 2010/05/23
- Re: gnulib tests leftovers, Jim Meyering, 2010/05/23
- Re: gnulib tests leftovers, Ralf Wildenhues, 2010/05/23
- Re: gnulib tests leftovers, Jim Meyering, 2010/05/23
- init.sh and C tests, Bruno Haible, 2010/05/23
- Re: init.sh and C tests, Jim Meyering, 2010/05/23
- Re: init.sh and C tests, Bruno Haible, 2010/05/23
Re: gnulib tests leftovers,
Ralf Wildenhues <=