[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: New module argp-version-etc
From: |
Sergey Poznyakoff |
Subject: |
Re: New module argp-version-etc |
Date: |
Wed, 24 Jun 2009 20:35:09 +0300 |
Eric Blake <address@hidden> ha escrit:
> Why'd you drop the comments describing what the method does?
I did not. I simply retained the original comment before version_etc_va.
I should have supplied comments before the two new functions, that's
true. I'll fix this.
> I'd like to see the arguments reversed:
>
> const char *authors[], size_t n_authors
No problem.
> > + for (n_authors = 0;
> > + n_authors < 10
> > + && (authtab[n_authors++] = va_arg (authors, const char *)) != NULL;
> > + n_authors++)
> > + ;
>
> missing va_end
Is it really necessary here? I believe the caller should call
va_end, because that's the caller who called va_start. Am I missing
something?
> > +test-ave (dummy) 0
> > +Copyright (C) 2009 Free Software Foundation, Inc.
>
> Are we going to have to update this test every year? It would be nice to
> compute the year that should be present, rather than hard-coding it
I thought about it too. But there is no warranty the computed year will
coincide with the COPYRIGHT_YEAR constant from version-etc.c.
Regards,
Sergey
- New module argp-version-etc, Sergey Poznyakoff, 2009/06/24
- Re: New module argp-version-etc, Eric Blake, 2009/06/24
- Re: New module argp-version-etc,
Sergey Poznyakoff <=
- Re: New module argp-version-etc, Sergey Poznyakoff, 2009/06/24
- Re: New module argp-version-etc, Bruno Haible, 2009/06/24
- Re: New module argp-version-etc, Sergey Poznyakoff, 2009/06/25
- Re: New module argp-version-etc, Jim Meyering, 2009/06/25
- Re: New module argp-version-etc, Sergey Poznyakoff, 2009/06/25
- Re: New module argp-version-etc, Jim Meyering, 2009/06/25
- Re: New module argp-version-etc, Paolo Bonzini, 2009/06/25
- Re: New module argp-version-etc, Bruno Haible, 2009/06/26