bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Use "$(MKDIR_P) sys", not race-prone "test -d sys || mkdir sys".


From: Ralf Wildenhues
Subject: Re: Use "$(MKDIR_P) sys", not race-prone "test -d sys || mkdir sys".
Date: Tue, 23 Jan 2007 19:54:28 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

* Paul Eggert wrote on Tue, Jan 23, 2007 at 12:00:35AM CET:
> 
> Thanks, please apply, except please change this comment:
[...]
> to this (just rewording):

Done, thanks.  For autoconf-patches records, here's what I committed.

Cheers,
Ralf

2007-01-23  Ralf Wildenhues  <address@hidden>
 
        * lib/autoconf/programs.m4 (AC_PROG_MKDIR_P): Also
        AC_SUBST([MKDIR_P]), so that Automake < 1.10 will pick up its
        trace, if a package uses AC_PROG_MKDIR_P explicitly.  The actual
        substitution will still be done by the special code.
        Report by Jim Meyering.

Index: lib/autoconf/programs.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/autoconf/programs.m4,v
retrieving revision 1.64
diff -u -r1.64 programs.m4
--- lib/autoconf/programs.m4    11 Jan 2007 21:17:37 -0000      1.64
+++ lib/autoconf/programs.m4    23 Jan 2007 18:53:54 -0000
@@ -682,8 +682,12 @@
     MKDIR_P="$ac_install_sh -d"
   fi
 fi
-dnl Do special magic for MKDIR_P instead of AC_SUBST, to get
-dnl relative names right.
+dnl status.m4 does special magic for MKDIR_P instead of AC_SUBST,
+dnl to get relative names right.  However, also AC_SUBST here so
+dnl that Automake versions before 1.10 will pick it up (they do not
+dnl trace AC_SUBST_TRACE).
+dnl FIXME: Remove this once we drop support for Automake < 1.10.
+AC_SUBST([MKDIR_P])dnl
 AC_MSG_RESULT([$MKDIR_P])
 ])# AC_PROG_MKDIR_P
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]