Re: strings.h in argz.c?

[Simon Josefsson]

Ralf Wildenhues <address@hidden> writes:

> We got a bug report about Libtool 1.5.22 and SunOS 4.1.x this year, so
> I'm not doing any C89 cleanup on branch-1-5.

That's not a problem, I only meant it to apply to future version.  (I
assume there will be future versions not based on branch-1-5 ;-)).

> OTOH, the change may eventually cause 2 less header checks in user code;
> that is, once all other checks for string.h and strings.h are eliminated
> from their configury.

Yes, and another problem might be code that checks for strings.h
and/or memory.h, but not string.h.  It seems they might get the wrong
headers..

I don't know about math.h.  Math functions seem generally more
optional than other functions to me, depending on platform.  If your
patch only changed this for the self tests, that is probably OK, but
it seems weird for libtool/ltdl to require math functions.

> WDYT?
...
>       * libltdl/argz.c: Do not include strings.h nor memory.h, include
>       string.h unconditionally.
>       Patch by Simon Josefsson <address@hidden>.

I like this part. :-)

Thanks,
Simon