[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug-gnulib] Re: same, utimecmp should depend on minmax
From: |
Paul Eggert |
Subject: |
[bug-gnulib] Re: same, utimecmp should depend on minmax |
Date: |
Mon, 23 May 2005 11:57:16 -0700 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.4 (gnu/linux) |
Bruno Haible <address@hidden> writes:
> The following heuristics works very well in practice:
> - First comes the #include "..." specifying the module being implemented.
> - Then come all the #include <...> of system or system-replacement headers,
> in arbitrary order.
> - Then come all the #include "..." of gnulib and private headers, in
> arbitrary order.
>
> This little problem with minmax.h is now fixed,
Sorry, I don't follow this. Won't this run into a problem when (for
example) private headers include system headers? E.g.,
// module being implemented
#include "my-interface.h"
// system headers
#include <stdio.h>
// gnulib and private headers
#include "minmax.h"
#include "private-header.h"
where private-header.h includes <utility.h> when HAVE_UTILITY_H, and
this happens to be the first inclusion of <utility.h>. (Solaris 10
<utility.h> defines MIN.)
And it's not just private headers: gnulib headers could have the same
problem.
- [bug-gnulib] same, utimecmp should depend on minmax, Derek Price, 2005/05/17
- Re: [bug-gnulib] same, utimecmp should depend on minmax, Paul Eggert, 2005/05/19
- Re: [bug-gnulib] same, utimecmp should depend on minmax, Derek Price, 2005/05/19
- Re: [bug-gnulib] same, utimecmp should depend on minmax, Paul Eggert, 2005/05/19
- Re: [bug-gnulib] same, utimecmp should depend on minmax, Derek Price, 2005/05/19
- Re: [bug-gnulib] same, utimecmp should depend on minmax, Paul Eggert, 2005/05/20
- Re: [bug-gnulib] same, utimecmp should depend on minmax, Derek Price, 2005/05/20
- Re: [bug-gnulib] same, utimecmp should depend on minmax, Paul Eggert, 2005/05/21
- [bug-gnulib] Re: same, utimecmp should depend on minmax, Bruno Haible, 2005/05/23
- [bug-gnulib] Re: same, utimecmp should depend on minmax, Simon Josefsson, 2005/05/23
- [bug-gnulib] Re: same, utimecmp should depend on minmax,
Paul Eggert <=
- [bug-gnulib] Re: same, utimecmp should depend on minmax, Bruno Haible, 2005/05/23