Re: [Bug-gnubg] Recent changes in sound.c

[Michael Petch]

On 4/17/08 2:10 AM, "Massimiliano Maini" <address@hidden> wrote:

> Hi all, 
>
> compiling the latest code (20080417) under Win I get: 
>
> In file included from sound.c:33: 
> backgammon.h:432: warning: `libintl_printf' is an unrecognized format function type 
> backgammon.h:435: warning: `libintl_printf' is an unrecognized format function type 
> backgammon.h:440: warning: `libintl_printf' is an unrecognized format function type 
> backgammon.h:443: warning: `libintl_printf' is an unrecognized format function type 
>
> This is just a warning, I think it can be fixed moving the include og gi18n.h after 
> the one of backgammon.h. 
>
> More serious, compiling the command line version (no GUI): 
>
> sound.c: In function `playSound': 
> sound.c:343: error: `fX' undeclared (first use in this function) 
> sound.c:343: error: (Each undeclared identifier is reported only once 
> sound.c:343: error: for each function it appears in.) 
>
> MaX.

Moving the include for the first issue is correct. The second one modify your sound.c so that:

    if (!fX || gs == SOUND_EXIT)
        playSoundFile( sound, TRUE );
    else 
        playSoundFile( sound, FALSE );

To (the fX check only applies when GTK is in use, which doesn’t apply to nogui builds):

#if USE_GTK
        if (!fX || gs == SOUND_EXIT)
#else
        if (gs == SOUND_EXIT)
#endif
                playSoundFile( sound, TRUE );
        else
                playSoundFile( sound, FALSE );


I’ll put this change away into  CVS, can you let me know if it works first.