Re: [Bug-gnubg] Problems with the recent changes regarding sounds

[Jonathan Kinsey]

Philippe Michel wrote:
> When configured without sound, gtkoptions.c doesn't compile any more :
> 
> gtkoptions.c:1793: error: `NUM_SOUNDS' undeclared here (not in a function)
> gtkoptions.c: In function `SetSoundSettings':
> gtkoptions.c:1806: error: `fSound' undeclared (first use in this function)
> gtkoptions.c:1806: error: (Each undeclared identifier is reported only once
> gtkoptions.c:1806: error: for each function it appears in.)
> gtkoptions.c: In function `SoundDefaultClicked':
> gtkoptions.c:1850: warning: initialization makes pointer from integer
> without a cast
> gtkoptions.c: In function `SoundSelected':
> gtkoptions.c:1927: error: `aszSoundDesc' undeclared (first use in this
> function)
> gtkoptions.c: In function `AddSoundWidgets':
> gtkoptions.c:2110: warning: initialization makes pointer from integer
> without a cast
> gtkoptions.c:2116: error: `aszSoundDesc' undeclared (first use in this
> function)
> gtkoptions.c: At top level:
> gtkoptions.c:1793: error: storage size of `soundDetails' isn't known
> *** Error code 1
> 
> There are some #if USE_SOUND blocks further down in this file (starting
> around line 1970) but it looks like more of the code should be subject
> to this condition.

Yes, thought this wouldn't work but can't look at it at the moment as
things don't compile here.

More generally I don't like #if blocks - they tend to make the code
tricky to maintain (when used excessively).  Is there any real overhead
of compiling the sound code (and turning the sound off)?  Similarly some
of the other blocks - time controls for example, could easily be
included in all builds?

Jon

signature.asc
Description: OpenPGP digital signature