Re: [Bug-gnubg] Using the ru_RU.KOI8-R locale causes a segfault

[Jonathan Kinsey]

Russ Allbery wrote:
> I got, and confirmed, a report from a Debian user that starting gnubg in
> the ru_RU.KOI8-R locale causes a segfault after clicking on New Game.
> This doesn't seem to affect other locales (I tried German).  It seems
> suspiciously like a memory clobber.  The backtrace isn't particularly
> useful:
> 
> (gdb) bt
> #0  0xb7ee1335 in ?? ()
>    from /usr/lib/gtk-2.0/2.4.0/loaders/libpixbufloader-xpm.so
> #1  0x00000000 in ?? ()
> 
> I'm happy to help with further debugging, but am not sure the best way to
> go about doing so.  valgrind reports an access to memory that isn't on the
> stack or malloc'd (after bumping the valgrind error limit -- gnubg
> produces a *ton* of valgrind errors, many of which in its dependent
> libraries) deep inside the XPM loader, and I couldn't see anything
> obviously wrong with the call site.

Just tracked down a bug (which I think was a different report as I'm
using German); anyway one of the buffers in ShowBoard() was getting
overwritten.

The idea of having a fixed length buffer the exact size of text that is
then translated is a problem...  I should check in the fix later but you
can check if it's causing your problem as well be increasing the size of
the buffers (just change 3? to 50 on 3329+3330 in gnubg.c).

Jon

signature.asc
Description: OpenPGP digital signature