[Bug-gnubg] Portability problems in the recent checkin of gtktexi.c

[Philippe Michel]

The latest update of gtktexi.c does not compile on my system (FreeBSD 5.4) 
:

gtktexi.c:36:16: io.h: No such file or directory
gtktexi.c: In function `EndElement':
gtktexi.c:978: error: `R_OK' undeclared (first use in this function)
gtktexi.c:978: error: (Each undeclared identifier is reported only once
gtktexi.c:978: error: for each function it appears in.)
gtktexi.c: At top level:
gtktexi.c:1414: warning: static declaration of 'MouseMove' follows 
non-static declaration
gtktexi.c:148: warning: previous implicit declaration of 'MouseMove' was 
here

and then (after fixing the io.h/R_OK problem) :

gtktexi.o(.text+0x467): In function `GetEntity':
/home/pm/src/gnubg/gtktexi.c:615: undefined reference to `stricmp'
gtktexi.o(.text+0x481):/home/pm/src/gnubg/gtktexi.c:619: undefined 
reference to `stricmp'
gtktexi.o(.text+0x49b):/home/pm/src/gnubg/gtktexi.c:623: undefined 
reference to `stricmp'
gtktexi.o(.text+0x4b5):/home/pm/src/gnubg/gtktexi.c:627: undefined 
reference to `stricmp'
gtktexi.o(.text+0x4cf):/home/pm/src/gnubg/gtktexi.c:631: undefined 
reference to `stricmp'
gtktexi.o(.text+0x4ed):/home/pm/src/gnubg/gtktexi.c:635: more undefined 
references to `stricmp' follow

It looks like some apparently Windows-specific code was added. In other 
source files, one can find includes of sys/unistd.h that provide a 
definition for R_OK. strcasecmp() is already used in various places 
instead of stricmp() as well.

With these 2 changes (I didn't bother with the MouseMove warnings), it 
builds fine, and then coredumps on Help|Commands...

Best regards,

Philippe Michel