Re: [Bug-gnubg] Compiling on Linux without GTK

[Jim Segrave]

On Mon 03 Mar 2003 (17:50 +0000), Joern Thyssen wrote:
> On Mon, Mar 03, 2003 at 06:31:11PM +0100, Nis wrote
> > After having implemented a rough version of the x.5-ply evaluation, I 
> > though I would try to compile it.
> > 
> > After having upgraded my autoconf and automake (it would be nice if the 
> > installation documentation mentioned that this is needed), I ran into 
> > problems with compiling without GTK - something which I guess should be 
> > working ...
> 
> Yes, "configure --without-gtk --without-gtk2 --without-x"  followed by
> "make" should be a usable gnubg.
 
It doesn't quite work - having just tried it. I'll commit some simple
patches (a few #if USE_GTK/#endifs in gnubg.c and renderprefs.c) that
make it compile after such a configure.


> > I managed to make the program compile - but I am not sure I did this in a 
> > "logical" way. Would it be possible that someone with a bit more knowledge 
> > of what all these settings do could look at my changes? What is the general 
> > "procedure" of doing this? Do I just do a diff and submit my changes?

> Yes, but please do a diff -u or diff -c, and if it's a huge patch please
> compress it :-) And if it's possible it would like these changes
> separate from the half-ply changes :-)

diff -u is really the only way to go in my opinion.

The problems were:

gnubg.c - CommandSetGUIDragTargetHelp only gets created if USE_GTK is
          true
          fGUISetWindowPos is only defined if USE_GTK is true (moved
          the #if USE_GTK up to remove the save of window positions

renderprefs.c - SetColourX() has a parameter of type gdouble - #if'ed
          out this function, as it's static
          #if'ed out the call to SetColourX() later on
          #if'ed out the SetColourSSF() function - again gdouble parameters
          #if'ed out the body of RenderPreferencesParam() to avoid the
           call to SetColourSSF()


-- 
Jim Segrave           address@hidden