Re: [PATCH 0/4] Cross compiling sharutils

[Eli Zaretskii]

> Date: Thu, 21 May 2015 21:50:55 -0700
> From: Filipe Brandenburger <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden
> 
> I tried to go deeper in the mingw experiment, by actually building
> sharutils with a modified popen without the "b" modifier. But I didn't
> really get to build it in mingw/msys. I can run ./configure fine, but
> make chokes when compiling lib/idcache.c that wants to #include
> <pwd.h> which is not there (among other problems, it's not just this
> one.)

When I ported Sharutils to MinGW, I indeed added that header (and also
grp.h.).

> In any case, this all seems to corroborate that mingw does indeed need
> the "b" modifier and that using the check for O_BINARY being defined
> to a non-zero value is a good way to determine whether to pass the "b"
> to popen and fopen calls or not.
> 
> Do you still have any objections to this O_BINARY approach?

No.