[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Problem building sharutils 4.14 on AIX 6.1
|
From: |
Eric Blake |
|
Subject: |
Re: Problem building sharutils 4.14 on AIX 6.1 |
|
Date: |
Mon, 21 Oct 2013 22:11:27 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 |
On 10/21/2013 12:14 PM, Thomas Jahns wrote:
> Hello,
>
> I built sharutils 4.14 on AIX 6.1 and initially got the following errors when
> compiling scribble.c:
>
> So I gathered scribble.c indirectly included a home-brew version of unistd.h
> that configure generated. I was able to fix above problem by adding an
>
> #ifdef HAVE_CONFIG_H
> #include "config.h"
> #endif
The #ifdef HAVE_CONFIG_H is needless fluff. We _know_ that we have
config.h, so just unconditionally include it. But yes, any projec that
uses gnulib MUST include "config.h" prior to any system headers, so this
is a bug in sharutils. Furthermore, gnulib comes with a syntax check
mechanism that scans the code base for problems like these; maybe it's
worth investigating the use of that syntax checker before the next
sharutils release.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature