Re: [gawk-stable] bug: fatal error when getline from directory

[Paolo]

On Fri, Jan 09, 2009 at 11:40:14PM +0100,  wrote:
> 
> Note there's a problem with my hack, in that iop_open() won't opendir() 

fixed in diff attached - still just a POC, but at least it's a fixed POC :)

> But seems there's a deeper problem with all such specfd stuff, eg:

uh, free() on a statically allocated struct :} 
fixed - er POC of workaround:

#-[io.c specfdopen()]--
- iop->flag |= IOP_NO_FREE;
+ iop->flag |= IOP_NOFREE_OBJ;

so spec_setup() is no more used; the whole thing looks a bit messy to me, 
yet seems to yield expected result now; pls see attached .out, obtained 
with pgawk, where -orig means plain Debian's 1:3.1.5.dfsg-4.3. 
There seems to be no mem leakage.


thx
-- 
paolo

awk-orig_sock-no-2nd-close.out
Description: Text document

awk_dir-no-2nd-close.out
Description: Text document

awk_dir.out
Description: Text document

awk_sock-no-2nd-close.out
Description: Text document

awk_sock.out
Description: Text document

awkprof-orig_sock-no-2nd-close.out
Description: Text document

awkprof_dir-no-2nd-close.out
Description: Text document

awkprof_dir.out
Description: Text document

awkprof_sock-no-2nd-close.out
Description: Text document

awkprof_sock.out
Description: Text document

gawk-3.1.5.1_io.c.diff
Description: Text document

gawk-3.1.5_awk.h.diff
Description: Text document

awk-orig_sock.out
Description: Text document

awkprof-orig_sock.out
Description: Text document