bug-gnu-utils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

pic2plot makes doody from carriage returns


From: ronburk
Subject: pic2plot makes doody from carriage returns
Date: Tue, 25 Sep 2007 08:38:54 -0000
User-agent: G2/1.0

Seems like pic2plot (2.5) just silently produces not-useful output
when handed an input file with CR/LF terminated lines.

I think it's because, despite numerous checks for "illegal" (ain't
really no law against carriage returns, but...) characters, there are
numerous additional cases where getc() is called, but the character's
validity is not correctly checked.

In particular, when do_file() (in main.cc) has seen a .PS and then
encounters a '\r', it decides that it should just ignore this line.
Since there will be no further ".PS lines" in the input to get things
started, that means that the entire input file is just silently
discarded.

Personally, I would rather see pic2plot just silently ignore carriage
returns in the input, but either way, seems like some cleanup is
required to really fix the root of the problem.

plotutils doesn't seem to be one of those projects with a source code
repository where you can just jump in and offer patches, hence my
posting in this newsgroup. Let me know if there is a more appropriate
place to send this information.

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]