[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gawk: invalid read and write
From: |
Andrew J. Schorr |
Subject: |
Re: gawk: invalid read and write |
Date: |
Sun, 28 Jan 2007 12:53:30 -0500 |
User-agent: |
Mutt/1.4.2.1i |
On Sun, Jan 28, 2007 at 06:45:41PM +0100, Jürgen Kahrs wrote:
> Andrew J. Schorr wrote:
>
> > Hmmm, my patch assumes the log files match this shell pattern: log.[0-9]*.
> > But I just realized that older versions of valgrind (e.g. 2.4.1)
> > use a different naming convention: log.pid[0-9]*. Is it worth
> > changing the patch to support the older valgrind?
>
> The implementation currently goes like
>
> awk '...' log.[0-9]*
>
> Wouldnt it be enough to just change it to
>
> awk '...' log.[0-9]* log.pid[0-9]*
Or, even more simply, log.* (if you include
both wildcards, then one may not have any matches, and
that will cause an error, I think).
Regards,
Andy