bug-gnu-utils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: multiple file processing doesn't work on sparc64


From: Aharon Robbins
Subject: Re: multiple file processing doesn't work on sparc64
Date: Wed, 27 Aug 2003 15:41:03 +0300

Re this:

> Date: Wed, 27 Aug 2003 08:19:34 +0200
> From: Stepan Kasal <address@hidden>
> To: Aharon Robbins <address@hidden>
> Cc: address@hidden, address@hidden
> Subject: Re: multiple file processing doesn't work on sparc64
>
> Hello,
>
> On Tue, Aug 26, 2003 at 03:41:00PM +0300, Aharon Robbins wrote:
> > > 'numfiles' is defined as 'long' in main.c and in awkgram it is defined as
> > > 'extern int'. While 'int' is 32-bit and 'long' is 64-bit on 64-bit
>
> > Much thanks for the report and patch.  The correct place to make the
> > change is in awkgram.y, since awkgram.c is built from that. I have
> > applied this fix to it.
>
> wouldn't it be saner to change numfiles to int in main.c?
> Can you imagine a platform where you really need long, yet you haven't
> hit any other limit?
>
> Sorry for the nit-picking.
>
> Stepan

No.  It's better to use long, which is at least 32 bits; int can
be 16 on some systems.  Repeat after me:

        No arbitrary limits.
        No arbitrary limits.
        No arbitrary limits.
        No arbitrary limits.
        No arbitrary limits.
        No arbitrary limits.
        No arbitrary limits.
        .....

Discussion closed.

Arnold




reply via email to

[Prev in Thread] Current Thread [Next in Thread]