Re: patch to grep

[Alfred M. Szmidt]

   attached is a patch for grep 2.5, that makes it so that
   "make DESTDIR=xxx install" works.

Goodie, I was annoyed about this too, but not annoyed enough to fix
it.  ;-) Some nitpicks about the patch though.

   --- src/Makefile.in.old      2003-01-07 02:01:07.900012783 -0800
   +++ src/Makefile.in  2003-01-07 02:02:02.840011000 -0800
   @@ -354,8 +354,8 @@


    install-exec-local:
   -    @SYMLINK@ @SYMLINKFROM@ $(bindir)/egrep
   -    @SYMLINK@ @SYMLINKFROM@ $(bindir)/fgrep
   +    @SYMLINK@ @SYMLINKFROM@ $(DESTDIR)$(bindir)/egrep
   +    @SYMLINK@ @SYMLINKFROM@ $(DESTDIR)$(bindir)/fgrep
    # Tell versions [3.59,3.63) of GNU make to not export all variables.
    # Otherwise a system limit (for SysV at least) may be exceeded.
    .NOEXPORT:

This is not your fault, but whom ever made the target.  If
$(bindir)/egrep or $(bindir)/fgrep exist then this target will fail.
It should remove the target first, and then make the links.  So:

-rm -f $(DESTDIR)$(bindir)/egrep $(DESTDIR)/$(bindir)/fgrep
@SYMLINK@ @SYMLINKFROM@ $(DESTDIR)$(bindir)/egrep
@SYMLINK@ @SYMLINKFROM@ $(DESTDIR)$(bindir)/fgrep

   --- ChangeLog.old    2003-01-07 01:44:01.780018572 -0800
   +++ ChangeLog        2003-01-07 01:45:04.680062000 -0800
   @@ -1,3 +1,7 @@
   +2002-03-13  Philip Brown <address@hidden>
   +    * patched src/Makefile.in and po/Makefile.in to respect
   +      DESTDIR variable, like all self-respecting GNU Makefiles should
   +
    2002-03-13  Bernhard Rosenkraenzer <address@hidden>
           * configure.in, m4/regex.m4, m4/malloc.m4, m4/realloc.m4:
             Don't set LIBOBJS directly, autoconf 2.53 doesn't like it

Please follow the GNU Coding Standards when creating ChangeLog
entries.  You can read more about the exact format in:
(standards)Change Logs.  The above ChangeLog entry should look
something like this:

2002-03-13  Philip Brown <address@hidden>

        * src/Makefile.in, po/Makefile.in: Added support for DESTDIR.

Or something along those lines.  One shouldn't really include the
ChangeLog entries in the patch since it the person applying the patch
might have made local modifications and this would screw up things
with .rej's and the like.  Instead just put the appropriate ChangeLog
above the patch (cvsdiff from cvs-utils [1] is a wonderful tool for
making patches look nice).


While I'm at it, some more nitpicks about the grep 2.5 release.
Please include the .msg files that get generated by gmsgfmt!  One
should not need to install gettext just to be able to get
international support in grep, gettext is only required by the people
doing the translations.  And if my memory serves me correct, do _NOT_
install the stuff in [grep]/intl/, this is bad since it might replace
an installed gettext and break it.  And finally, make the test scripts
executable. :)

[1]: http://savannah.gnu.org/projects/cvs-utils