Re: OS/2 Patches (4)

[Andreas Buening]

Bruno Haible wrote:
> 
> Andreas Buening writes:
> 
> > ---------------------------
> > --- old/gettext-0.11.5/src/msgfilter.c  Tue Apr 23 11:33:34 2002
> > +++ gnu/gettext-0.11.5/src/msgfilter.c  Sat Oct 19 21:05:48 2002
> > @@ -37,7 +37,7 @@
> >  #endif
> >
> >  /* Get fd_set.  */
> > -#ifdef _AIX
> > +#if defined(_AIX) || defined(__EMX__)
> >  # include <sys/select.h>
> >  #endif
> > ---------------------------
> 
> Why this? EMX <sys/types.h> already defines fd_set and the FD_* macros.

You've looked at the emx headers? :-)


> So what is <sys/select.h> good for?

It's for select(). It's declared only in io.h or sys/select.h.


> > It's a bad idea to redefine symbols from a library in a program,
> > program_name, to be exactly. I renamed it to local_program_name.
> 
> It'd better to declare it 'extern' instead.

Please do that. This would be okay for me.

[snip]


Bye,
Andreas