[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: ports/30713: 'gtar --version' segfaults (pwd)
From: |
Jason R. Mastaler |
Subject: |
Re: ports/30713: 'gtar --version' segfaults (pwd) |
Date: |
Fri, 21 Sep 2001 19:50:27 -0600 |
User-agent: |
Gnus/5.090004 (Oort Gnus v0.04) XEmacs/21.4 (Academic Rigor) |
See <http://www.freebsd.org/cgi/query-pr.cgi?pr=30713> for reference.
-------------------- Start of forwarded message --------------------
Date: Sat, 22 Sep 2001 02:56:25 +0200 (CEST)
From: Christian Weisgerber <address@hidden>
To: address@hidden,
address@hidden
X-Also-Posted-To: list.freebsd.ports
Subject: Re: ports/30713: 'gtar --version' segfaults
X-Newsreader: trn 4.0-test76 (Apr 2, 2001)
<address@hidden> wrote:
> >Description:
>
> I just upgraded my gtar port to 1.13.23, and get a segmentation fault
> when I run 'gtar --version'. Strangely, the program seems to work
> fine otherwise.
In an act of unprecedented ridiculousness gtar goes through contortions
with locales and iconv in order to obtain a "pretty" copyright
symbol, if the user's character set contains one.
On systems with insufficient locale support this code dereferences
a NULL pointer. It doesn't happen for me on 5.0-CURRENT, but I've
seen it on another platform.
The patchlet below should fix this.
--- /usr/ports/archivers/gtar/files/patch-lib_copysym.c Thu Jan 1 01:00:00 1970
+++ gtar/files/patch-lib_copysym.c Sat Sep 22 02:43:08 2001
@@ -0,0 +1,14 @@
+
+$FreeBSD$
+
+--- lib/copysym.c.orig Sat Sep 15 07:53:06 2001
++++ lib/copysym.c Sat Sep 22 02:42:33 2001
+@@ -60,7 +60,7 @@
+ #endif
+ }
+
+- if (*outcharset)
++ if (outcharset && *outcharset)
+ {
+ iconv_t conv = iconv_open (outcharset, "UTF-8");
+
--
Christian "naddy" Weisgerber address@hidden
-------------------- End of forwarded message --------------------
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: ports/30713: 'gtar --version' segfaults (pwd),
Jason R. Mastaler <=