[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Bug#68928: uudecode gives misleading error (fwd)
From: |
Santiago Vila |
Subject: |
Bug#68928: uudecode gives misleading error (fwd) |
Date: |
Wed, 8 Aug 2001 01:38:23 +0200 (CEST) |
Hello.
Almost a year ago, Goswin Brederlow reported the following bug using
the Debian bug system:
-----------------------------------------------------------------
uudecode demodisk.img.uu -o debian/tmp/usr/share/bochs/
uudecode: debian/tmp/usr/share/bochs/: demodisk.img.uu: Is a directory
That looks like demodisk.img.uu is a directory while its the one before.
A bit misleading.
-----------------------------------------------------------------
Yesterday, I have received the following patch (and explanation) from
Martin Michlmayr <address@hidden>.
(Thanks a lot for looking at this, Martin!)
-----------------------------------------------------------------
I think it's save to remove inname from the error() call since inname
is not mentioned in the if (i.e. inname cannot cause the error).
--- uudecode.c.orig Tue Aug 7 17:59:32 2001
+++ uudecode.c Tue Aug 7 17:59:42 2001
@@ -348,7 +348,7 @@
#endif
))
{
- error (0, errno, "%s: %s", outname, inname);
+ error (0, errno, "%s", outname);
return 1;
}
-----------------------------------------------------------------
I agree with the analysis made by Martin (if inname cannot cause the
error, it should be safe not to show it in the error message), so I
plan to apply his patch to the Debian version of sharutils, unless you
have a better idea.
Thanks.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Bug#68928: uudecode gives misleading error (fwd),
Santiago Vila <=