Re: AM_GNU_GETTEXT working with autoconf 2.50, yet again

[Bruno Haible]

Akim Demaille writes:

> First, formatting changes.  There are *only* formatting changes.  Not
> obvious given the length of the diffs, but trust me, there is not a
> single change other than formatting (and changequote actually).

This is not helpful. Everyone has a different taste. De gustibus not
disputandum est.

>       * configure.in: Do not use changequote.
>       * m4/gettext.m4: Do not use changequote.

This is a regression. You are replacing a reliable method, changequote,
by a less reliable one, namely duplicating random occurrences of brackets.
This is unreliable, as we have seen recently with the fileutils regex.m4
macro, which uses unbalanced brackets. With changequote no problems. Without
changequote, bugs.

> Then, the glue code between 2.13 and 2.50.
>
>        * m4/gettext.m4 (AM_WITH_NLS): Adjust the computation of
>        top_srcdir and ac_giveN-srcdir to be Autoconf 2.13/2.50
>        compatible.
>
>          # Autoconf 2.50 provides $srcdir and $top_srcdir.

No, autoconf 2.50 doesn't provide $top_srcdir in shell code that is executed
during config.status. Your addition of "if test "x$top_srcdir" = x; then"
is therefore a nop, because $top_srcdir is always empty.

But the line which fixes everything is

           : ${ac_given_srcdir=$srcdir}

Thanks for it.

Bruno