bug-gnu-utils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Bug in tar 1.13.19 ???


From: POSTLBAUER,JUAN (HP-Spain,ex1)
Subject: Bug in tar 1.13.19 ???
Date: Thu, 7 Jun 2001 15:30:34 +0200

Trying to compile under linux (SuSE 7.1, kernel 2.4) complains about O_TEXT
not defined.
True: "grep -r -e O_BINARY -e O_TEXT /usr/include" yields nothing.

I guess the patch would be in system.h, where you already do something
similar for O_BINARY
#ifndef O_BINARY
#define O_BINARY 0
#endif
then just do the same for O_TEXT

Also, as the numeric form of the open flags for the rmt protocol is retained
"for compatibility", it would be better to suppress form that number all
options causing compatibility problems.

Real case:
Tar is run in cygwin 1.1.8
rmt runs under linux (suse 7.1)

"rmt tvf host:/dev/st" fails, because tar uses O_BINARY, which under cygwin
is 0x10000, wich under linux is O_DIRECTORY. So you get error 20: no such
directory.

My proposed fix: send the full set of "open flags" in text form, but include
only "full cross flattform" options in the numeric form.
This way if the target is a new implementation it will correctly parse the
text form and discard the numeric form, whereas if it is and old
implementation it won't get confused misunderstunding the numeric option.

        Best regards
Juan Postlbauer
   BRS Technical Consultant
   Hewlett-Packard EspaƱola

 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]