Re: [bug-gnu-libiconv] ability to tag generated files with the right ccsid on z/OS

[Mike Fulton]

On Wed, Apr 5, 2023 at 5:05 PM Mike Fulton <mikefultonpersonal@gmail.com> wrote:

On Mon, Apr 3, 2023 at 3:11 PM Bruno Haible <bruno@clisp.org> wrote:

Mike Fulton wrote:
> > And has 'cat' been modified to add a charset indicator on file3
> > upon close() / fclose()?
> >
> Yes.

OK, then that's a justification for doing it in iconv as well.

> > If there is a lot of code for a specific platform to be integrated, I
> > _might_ request that it be separated out into a .h file.
> >
> It's not very much although depending on how I do the fix 'right' for the
> encoding mapping, perhaps that might belong in a separate file, but
> that's your call.

We'll see that when you submit it.

I have created the patch files (and tested them on z/OS) for the 

iconv changes and the unit tests that you requested. 

Please see: https://github.com/ZOSOpenTools/libiconvport/tree/zostagging/git-patches/zostagging

directory. I am happy to put it into whatever format you like. 

I have not tested on z/OS but the code and the unit test should be no-ops 

typo! I have not tested on a platform other than z/OS (I have tested on z/OS) 

unless I made a mistake.  

> > Also, I might request adding a unit test, since I don't want to write
> > a unit test for your code if, two years from now, someone reports a bug.
> >
> Will do. Is there a particular doc I should read that describes the process
> for
> a unit test or should I just read the test harness code?

There is no such doc. The structure of these unit tests is simple: each is
a command whose exit codes indicates success or failure.

Bruno