[bug-gnu-libiconv] [bug #62491] libcharset_set_relocation_prefix not exported

[Bruno Haible]

Update of bug #62491 (project libiconv):

                  Status:                    None => Not a Bug              
             Assigned to:                    None => haible                 
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #1:

I can see that the same patch is also found at
https://github.com/conan-io/conan-center-index/blob/master/recipes/libiconv/all/patches/0001-libcharset-fix-linkage.patch
and
https://github.com/microsoft/vcpkg/blob/master/ports/libiconv/0003-Add-export.patch

But it is wrong, because once the header is installed in a public location,
LIBCHARSET_DLL_EXPORTED needs to be defined as a C macro (otherwise the
package that uses this include file gets a syntax error).

And it is not needed, because at build time the package uses
include/libcharset.h.build.in (see configure.ac line 62), and this file does
contain a LIBCHARSET_DLL_EXPORTED definition and use.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?62491>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/