[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnu-libiconv] [libvirt] [PATCH] build: fix virBufferVasprintf o

From: Eric Blake
Subject: Re: [bug-gnu-libiconv] [libvirt] [PATCH] build: fix virBufferVasprintf on mingw
Date: Fri, 01 Jul 2011 10:13:00 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10

On 07/01/2011 07:50 AM, Eric Blake wrote:
> But now we have a problem - if gnulib did _not_ replace snprintf because
> it probed the mingw version and found that the return value was correct,
> then the libintl override violates gnulib's assumptions.  If gnulib
> _does_ replace snprintf, but does not support %1$d, then gnulib violates
> libintl's assumptions.

One bit of good news - I confirmed (by modifying test-vsnprintf, then
testing on mingw64, where the gnulib replacement _does_ kick in) that
gnulib's vsnprintf replacement supports %1$d out of the box without any
further m4 tests, and without having to drag in the vsnprintf-posix
module.  So at this point, the patch for mingw is as simple as ensuring
that the gnulib snprintf replacement always kicks in.  Proposed patch
coming up soon.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]