Re: [bug-gnu-libiconv] [PATCH] make genaliases* llp64 compatible

[Bruno Haible]

Hi Ozkan,

> I guess that comes down to the attached patch which adds just
> two entries to the configury and conditionally includes stdint.h
> or inttypes.h in lib/iconv.c.

Thanks for the patch. While completing it to handle also the '(long)'
casts in lib/aliases.h, leading to the attached patch, I noticed that
all relevant values are then casted to 'int'. In fact, all values are
>= 0 and < 1000000.

I conclude that the only problem are warnings that occur on platforms
where sizeof(long) != sizeof(void*). libiconv should work perfectly
fine also without the patch. Since the patch adds too much complexity,
just for avoiding some warnings on non-standard platforms, I'm not
applying it.

Bruno

0001-Avoid-warnings-on-systems-where-sizeof-long-sizeof-v.patch
Description: Text Data