[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnu-libiconv] Patch suggestion

From: Roumen Petrov
Subject: Re: [bug-gnu-libiconv] Patch suggestion
Date: Tue, 31 Mar 2009 23:48:54 +0300
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20090324 SeaMonkey/1.1.15

Hi Bruno,

Bruno Haible wrote:
Hi Roumen,

Thanks for proposing a good solution while I didn't have time to look at
Michael in der Wiesche's suggestions.

Roumen Petrov wrote on 2008-11-28 [1]:
The second (2) is only for resource isn't linked. The patch from this thread is obsolete and is part from 1.12.

I check the reported "resource issue" and confirm that problem exist.
The CVS HEAD version (makefiles with resources) is not changed I to me problems is not resolved.

I would like to propose a solution based on libtool. To the email is attach file libiconv-1.12.patch-RC. This file is only to show how libtool can compile and link windows resources.

The libtool provide a macro AC_LIBTOOL_RC (v<2). This macro isn't well documented. It has to be called before AC_PROG_LIBTOOL. For libtool (v>=2+) it is replaced with LT_LANG([Windows Resource]) called after LT_INIT. This macro detect resource compilers (windres for mingw) and enable a libtool tag (--tag=RC) to work.

Very nice! that libtool provides a solution for the problem that it
caused itself by dropping the .res file from the command line :-)

Thanks, but it was not complete patch. It was to show only how to use libtool to compile resource file and the sample was only for one of resource compiler use. It was a concept patch.

I didn't know about it, and have now used your suggestion in libiconv 1.13
(available at http://ftp.gnu.org/gnu/libiconv/libiconv-1.13.tar.gz) and
GNU gettext.

The complete solution is to replace all. Actually libiconv 1.12 use resource in two places(targets) and both don't work. I review 1.13 source and one of places is changed (lib/Makefile.in), but second not (in src/Makefile.in). Also configure.ac still contain
 AC_CHECK_TOOL([WINDRES], [windres]).

Too bad that 1.13 is already released. If I remember well 1.12 executable was linked without resource too. I will cross-compile v1.13 and I will keep you informed.


[1] http://lists.gnu.org/archive/html/bug-gnu-libiconv/2008-11/msg00014.html


P.S.: 10x for inclusion of bulgarian translation.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]