[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug-gnu-libiconv] Re: adding version identification to libiconv and lib
[bug-gnu-libiconv] Re: adding version identification to libiconv and libintl
Mon, 21 May 2007 02:45:22 +0200
Thanks for this first version identification infrastructure. Turning
to GNU hello was a good move, since it's simpler. The result looks good.
So it appears that a .res file can simply be added to the link command
line, with the GNU linker just like I did years ago with the MSVC linker?
And does that work also for shared libraries, i.e. can the .res file be
passed on the "libtool --mode=link gcc ... -o libiconv.la" command line?
> I don't know if you'd want to adapt this to gettext, but
> if you'd like to, I'm more than happy to send you the pieces.
Before you send me the pieces, maybe one modification is possible: I would
guess that the makewinrc.sh does not require special tools, only normal
text processing tools (cat, sed, etc.)? If this is true, there is an
opportunity to make the script invoke also $(WINDRES), to create the .res
file. This would reduce the modifications to the Makefile.am. (When possible,
one tries to put maximum functionality into helper scripts and have in the
Makefile.am only a minimum of logic.)
> I generated a context diff (diff -r -u3),
> and am pasting it subsequently
Your mailer added line breaking, which kills the ability to just feed the
patch into "patch < ...". It should work better, I hope, if you attach
the diffs as attachments.
> (apparently context diffs do not include new files,
"diff -r -u3 --unidirectional-new-file" does it.
I hope this is unrelated to the .res files? In the older MSVC port of gettext,
the executables were built for the "console" subsystem, IIRC. "windows"
subsystem is not a must?