bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline


From: Björn Lindström
Subject: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline
Date: Sat, 29 Jun 2024 13:59:03 +0200
User-agent: Cyrus-JMAP/3.11.0-alpha0-538-g1508afaa2-fm-20240616.001-g1508afaa

Hello,

updated patch attached, which ads a note to NEWS, and has a changed 
implementation of the insertion of missing newline inspired by the one from 
files.el. It's still slightly different to account for it also being possible 
to use on a region.

This time there's also an added test.

/ Björn

On Thu, Jun 27, 2024, at 09:37, Eli Zaretskii wrote:
>> Cc: 71499@debbugs.gnu.org, stefankangas@gmail.com, bkhl@elektrubadur.se
>> Date: Thu, 13 Jun 2024 11:30:51 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> 
>> Meanwhile, Björn, I have a few comments to the patch:
>> 
>>   . it needs a NEWS entry announcing the new feature
>>   . is there any reason your code to handle the missing newline is not
>>     identical to what the implementation of require-final-newline
>>     does?
>
> Ping!  Björn, can you please post an updated patch with the above nits
> taken care of?  We can install this now on the master branch.

Attachment: 0001-Make-whitespace.el-cleanup-add-missing-final-newline.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]