[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#71812: [PATCH] Flag checkdoc-package-keywords-flag as a :safe variab
From: |
Jules Tamagnan |
Subject: |
bug#71812: [PATCH] Flag checkdoc-package-keywords-flag as a :safe variable |
Date: |
Thu, 27 Jun 2024 22:23:59 -0700 |
Tags: patch
* Problem
Recently I was collaborating on a package that provided a .dir-locals.el
file where this `checkdoc-package-keywords-flag' was being set. I then
had to figure out what variable was considered unsafe and decide whether
it was unsafe or not. This caused some extra mental overhead and
development friction.
* Solution
It would be great if this variable were already considered safe to
reduce overhead on developers.
* Implementation
After looking at how this variable was used I noticed that it was only
consumed in `checkdoc-current-buffer' and that it seemed safe to mark as
safe. I added a single autoload line as is done throughout the rest of
the file for similar variables
---
Best,
Jules
---
In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.42, cairo version 1.18.0)
Repository revision: 9cb2a2040888c28587bed2b0902d9da90720f9a0
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101013
System Description: NixOS 24.11 (Vicuna)
Configured using:
'configure
--prefix=/nix/store/93m6yix8f6pcg75418xjx7k81lrj5a6s-emacs-git-20240626.0
--disable-build-details --with-modules --with-x-toolkit=gtk3
--with-cairo --with-xft --with-compress-install
--with-toolkit-scroll-bars --with-native-compilation
--without-imagemagick --with-mailutils --without-small-ja-dic
--with-tree-sitter --with-xinput2 --with-xwidgets --with-dbus
--with-selinux'
safe.patch
Description: Text Data
- bug#71812: [PATCH] Flag checkdoc-package-keywords-flag as a :safe variable,
Jules Tamagnan <=