[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.
From: |
Eli Zaretskii |
Subject: |
bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] |
Date: |
Thu, 27 Jun 2024 11:41:22 +0300 |
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sat, 22 Jun 2024 12:00:26 -0700
> Cc: iota@whxvd.name, monnier@iro.umontreal.ca, 65734@debbugs.gnu.org,
> Andrea Corallo <acorallo@gnu.org>
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Ihor Radchenko <yantar92@posteo.net>
> >> Cc: Sebastian Miele <iota@whxvd.name>, Stefan Monnier
> >> <monnier@iro.umontreal.ca>, Stefan Kangas <stefankangas@gmail.com>,
> >> 65734@debbugs.gnu.org
> >> Date: Wed, 19 Jun 2024 14:01:12 +0000
> >>
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >>
> >> > The patches lack suitable ChangeLog-style commit log messages (see
> >> > CONTRIBUTE for details and you can use "git log" to show examples of
> >> > how we do this).
> >> >
> >> > I'd also ask Stefan Monnier and Stefan Kangas to review the patch,
> >> > since this is an important command and I would like to avoid breaking
> >> > it.
> >>
> >> Please see the attached edited patches with proper commit messages.
> >
> > Stefan, Stefan and Andrea, could you please review this? If you see
> > no problems, let's install this in Emacs 30.
>
> The patch and proposed behavior makes sense to me.
Thanks, I've now installed this on the emacs-30 branch, and I'm
closing the bug.
Btw, the new tests broke simple-tests (because they caused packages be
loaded that affected the completion tested by one of the tests. I
fixed that, but please always run the relevant test files whenever you
modify them, don't assume that adding or modifying a test will never
affect other tests in the same file.