[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} comman
From: |
Jules Tamagnan |
Subject: |
bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands |
Date: |
Mon, 24 Jun 2024 11:11:16 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hi Eli,
Thank you for the review, I really appreciate it.
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: 71716@debbugs.gnu.org
>> From: Jules Tamagnan <jtamagnan@gmail.com>
>> Date: Sun, 23 Jun 2024 15:08:43 -0700
>>
>> +(defcustom completion-preview-context-variables '(char-script-table
>> + forward-sexp-function
>> +
>> find-word-boundary-function-table
>> + inhibit-field-text-motion)
>> + "List of variables which can change the functionality of `forward-word'
>> +or `forward-sexp'."
>> + :type '(repeat (variable :tag "Variable" :value char-script-table))
>> + :version "30.1")
>
> I don't think we will install new features on the emacs-30 branch, so
> this :version tag should be updated. And the previous one as well, I
> guess.
My latest patch for this change actually removed this variable entirely
but I'll keep this in mind going forward.
>> +(defun completion-preview--determine-substring (command string)
>> + "A helper function to determine what parts of a STRING come before and
>> +after the point when a certain COMMAND has been performed on that STRING"
>
> The first line of a doc string should be a single complete sentence.
> That's because some help commands, like "M-x apropos", show only the
> first line of the doc strings.
Similarly, I've removed this function definition but will keep this in
mind. Thank you.
Best,
Jules
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Jules Tamagnan, 2024/06/22
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Eshel Yaron, 2024/06/22
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Jules Tamagnan, 2024/06/22
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Jules Tamagnan, 2024/06/22
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Eshel Yaron, 2024/06/23
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Jules Tamagnan, 2024/06/23
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Jules Tamagnan, 2024/06/23
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Eli Zaretskii, 2024/06/24
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands,
Jules Tamagnan <=
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Eshel Yaron, 2024/06/24
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Jules Tamagnan, 2024/06/24
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Eshel Yaron, 2024/06/26
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Jules Tamagnan, 2024/06/28
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Eshel Yaron, 2024/06/28
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Juri Linkov, 2024/06/27
- bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands, Eshel Yaron, 2024/06/27