[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#70105: 30.0.50; Emacs should support EditorConfig out of the box
From: |
Stefan Monnier |
Subject: |
bug#70105: 30.0.50; Emacs should support EditorConfig out of the box |
Date: |
Tue, 18 Jun 2024 15:37:52 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
>>> In particular, Org mode needs to use a fixed `tab-width' and
>>> editorconfig must not override that (it is a part of the syntax).
>> I don't understand: `tab-width` mostly affects the display, how can it
>> break Org mode?
> Because Org mode syntax depends on indentation for lists:
>
> - parent list
> - sub-list
> - sub-sub-list
>
> When the indentation has tabs in it, (current-indentation) return value
> becomes a variable of `tab-width'. As a result, Org file syntax
> unexpectedly becomes dependent on seemingly unrelated Emacs
> configuration toggle.
> (I also considered let-binding `tab-width' when Org parser the file, but
> lists will then look funny visually)
If you use the `tab-width` set by the user then you have the advantage
that you parse the code in a way that is consistent with what the users
see (so the problem only bites the users who don't look at their code).
If you parse with a fixed `tab-width` OTOH the user may be puzzled
because the code looks like one thing to them but you parse it as
something else.
>> In any case, Org is not the only mode with such needs (Makefile, Haskell,
>> Python, come to mind). But also, disabling editorconfig wholesale seems
>> a bit crude. Maybe we'll need a more targeted way to address the problem
>> (and there's always `hack-local-variables-hook`).
> I did not imply that editorconfig should be _completely_ disabled.
> Just for tab-width in our case.
I mentioned it because that's the option that the upstream package offers.
> I guess that `hack-local-variables-hook' should be an ok
> option. Although it feels a bit funny to:
> 1. Set tab-width in org-mode body
> 2. Set it again in hack-local-variables-hook
There's also the option of saying that it's the user's fault.
It's hard to tell in general what would be the right behavior, so
I think it's important we look at concrete cases.
> Hmm... Sorry, I cannot see anything in the list archives.
> Either I made things up in my mind or it was discussed on IRC/Matrix.
I guess we'll have to wait to see if the issue pops up again.
Stefan
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Stefan Monnier, 2024/06/06
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Eli Zaretskii, 2024/06/08
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Stefan Monnier, 2024/06/09
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Stefan Monnier, 2024/06/18
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Ihor Radchenko, 2024/06/18
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Stefan Monnier, 2024/06/18
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Ihor Radchenko, 2024/06/18
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box,
Stefan Monnier <=
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Ihor Radchenko, 2024/06/18
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Stefan Monnier, 2024/06/18
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Björn Bidar, 2024/06/18
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Stefan Monnier, 2024/06/18
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Stefan Kangas, 2024/06/18
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Stefan Monnier, 2024/06/18
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Stefan Monnier, 2024/06/18
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Rudolf Schlatte, 2024/06/19
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Stefan Kangas, 2024/06/19
- bug#70105: 30.0.50; Emacs should support EditorConfig out of the box, Michael Albinus, 2024/06/19