[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffe
From: |
Eshel Yaron |
Subject: |
bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted |
Date: |
Mon, 17 Jun 2024 09:40:30 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hi Juri,
Juri Linkov <juri@linkov.net> writes:
>> When point is on an entry, then 'tabulated-list-print'
>> moves point to the entry with the same ID.
>>
>> However, what ID to prefer for outline heading lines
>> is not quite clear. Possible variants:
>>
>> 1. The simplest way would be to remember the position of point
>> or the line number. But this is not quite reliable
>> when new entries are inserted before.
>>
>> 2. Remembering the outline heading line as a string and searching for it
>> afterwards would be ambiguous when there are more headings with the
>> same string. For example, when at the top level there are project names,
>> and at the second level mode names repeated for every project.
>>
>> 3. To remember a complete path like outline-hidden-headings-paths does,
>> e.g. '("Project1 name" "Mode2 name").
>
> The third variant is implemented now.
Works like a charm here, thank you!
>> But this will not handle modes that don't use tabulated-list.
>> For example, reverting an xref buffer with outlines now restores
>> visibility of outlines, but doesn't restore point. OTOH, maybe it's
>> not responsibility of outline-minor-mode to restore point when it's
>> not on a heading line.
>
> For xref I propose a separate patch that keeps point on the same line
> after reverting the xref buffer:
LGTM, but FWIW the situation with xref-revert-buffer is not ideal IMO:
it might be cleaner to leave 'g' bound to the usual revert-buffer and
set revert-buffer-function to (a slightly modified) xref-revert-buffer.
That way xref-revert-buffer wouldn't need to duplicate generic parts of
revert-buffer, such as running revert-buffer-restore-functions. WDYT?
Eshel
- bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted, Eshel Yaron, 2024/06/10
- bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted, Juri Linkov, 2024/06/11
- bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted, Juri Linkov, 2024/06/17
- bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted,
Eshel Yaron <=
- bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted, Dmitry Gutov, 2024/06/17
- bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted, Eshel Yaron, 2024/06/17
- bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted, Dmitry Gutov, 2024/06/17
- bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted, Eshel Yaron, 2024/06/18
- bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted, Eli Zaretskii, 2024/06/18
- bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted, Eshel Yaron, 2024/06/18
- bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted, Eli Zaretskii, 2024/06/18
- bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted, Eshel Yaron, 2024/06/18
- bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted, Dmitry Gutov, 2024/06/18
- bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted, Eli Zaretskii, 2024/06/18