[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#71438: [PATCH] Allow ping to receive optional arguments
From: |
Eli Zaretskii |
Subject: |
bug#71438: [PATCH] Allow ping to receive optional arguments |
Date: |
Sun, 09 Jun 2024 18:21:13 +0300 |
> From: TOMAS FABRIZIO ORSI <torsi@fi.uba.ar>
> Date: Sun, 9 Jun 2024 12:03:37 -0300
> Cc: pbreton@cs.umb.edu, 71438@debbugs.gnu.org
>
> Stefan Kangas said:
> > Consider adding a ChangeLog entry to the commit message, see CONTRIBUTE.
>
> Noted. I thought my patch was too small to be mentioned in ChangeLog.
> I'll keep this in mind for future patches :D.
> As a side note, I found the CONTRIBUTE file very helpful.
> I personally found
> https://www.gnu.org/software/emacs/manual/html_node/emacs/Contributing.html
> to be a bit unclear.
I suggest instead to read the file CONTRIBUTE in the top-level
directory of the Emacs source tree.
> Eli Zaretskii said:
> > Yes, I think we should do that, in which case the change is no longer
> backward-incompatible.
>
> Great! What's the procedure now? Should I upload a new patch to this
> same thread with the changes you both mentioned?
Yes, please .
> As a side note, any additional notes?
> Any style comments?
Just one: try to keep lines shorter than 80 columns, and break longer
lines into several ones.
> Elisp advice? Any other function I should look into
> to "imitate" the style of a good use of prefix argument?
Any command that uses the fact of being invoked with a prefix argument
to modify its behavior will do.
- bug#71438: [PATCH] Allow ping to receive optional arguments, (continued)
- bug#71438: [PATCH] Allow ping to receive optional arguments, Eli Zaretskii, 2024/06/09
- bug#71438: [PATCH] Allow ping to receive optional arguments, TOMAS FABRIZIO ORSI, 2024/06/09
- bug#71438: [PATCH] Allow ping to receive optional arguments, Stefan Kangas, 2024/06/09
- bug#71438: [PATCH] Allow ping to receive optional arguments, TOMAS FABRIZIO ORSI, 2024/06/09
- bug#71438: [PATCH] Allow ping to receive optional arguments, TOMAS FABRIZIO ORSI, 2024/06/16
- bug#71438: [PATCH] Allow ping to receive optional arguments, Stefan Kangas, 2024/06/16
- bug#71438: [PATCH] Allow ping to receive optional arguments, TOMAS FABRIZIO ORSI, 2024/06/16
- bug#71438: [PATCH] Allow ping to receive optional arguments, Stefan Kangas, 2024/06/17
- bug#71438: [PATCH] Allow ping to receive optional arguments, TOMAS FABRIZIO ORSI, 2024/06/18
- bug#71438: [PATCH] Allow ping to receive optional arguments, Stefan Kangas, 2024/06/20
- bug#71438: [PATCH] Allow ping to receive optional arguments,
Eli Zaretskii <=