[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php
From: |
Vincenzo Pupillo |
Subject: |
bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php |
Date: |
Fri, 07 Jun 2024 19:02:52 +0200 |
In data venerdì 7 giugno 2024 15:39:04 CEST, Andrea Corallo ha scritto:
> Vincenzo Pupillo <v.pupillo@gmail.com> writes:
> > Ciao Andrea,
> > I think the warning is due to html-ts-mode. It checks whether or not the
> > parser exists, but even if it does not exist it tries to create it: ...
> >
> > (unless (treesit-ready-p 'html)
> >
> > (error “Tree-sitter for HTML isn't available”))
> >
> > (treesit-parser-create 'html)
>
> What is not clear to me is why we should run this while compiling
> php-ts-mode.
I don't know. Maybe because there is a '(require 'html-ts-mode)' ?
> > ....
> >
> > I fixed it by replacing “unless” with “if” ...
> > Do I open another bug for this patch?
>
> But in that case one could activate html-ts-mode even with no parser? 🤔
>
I don't think so. Because if the parser is not there, the rest of the code is
not executed. I don't know the details, but all '*-ts modes' do this.
> > Ok for the ";; Maintainer".
> > Go ahead and bother me! :D
> :
> :D
>
> Thanks
>
> Andrea
Ciao
Vincenzo
- bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php, (continued)
- bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php, Stefan Monnier, 2024/06/06
- bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php, Vincenzo Pupillo, 2024/06/07
- bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php, Stefan Monnier, 2024/06/07
- bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php, Vincenzo Pupillo, 2024/06/07
- bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php, Stefan Monnier, 2024/06/07
- bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php, Vincenzo Pupillo, 2024/06/07
bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php, Andrea Corallo, 2024/06/06