bug#71223: 30.0.50; stack overflow after very fast opening and closing of frames

[Eli Zaretskii]

> From: Daniel Clemente <n142857@gmail.com>
> Date: Mon, 27 May 2024 11:01:15 +0000
> 
> (gdb) xbacktrace 
> "sit-for" (0xffb4abf8)
> "server-return-error" (0xffb4adc0)
> "server-process-filter" (0xffb4b018)
> "sit-for" (0xffb4d108)
> "server-return-error" (0xffb4d2d0)
> "server-process-filter" (0xffb4d528)
> "sit-for" (0xffb4f618)
> "server-return-error" (0xffb4f7e0)
> "server-process-filter" (0xffb4fa38)
> "sit-for" (0xffb51b28)
> "server-return-error" (0xffb51cf0)
> "server-process-filter" (0xffb51f48)
> "sit-for" (0xffb54038)
> "server-return-error" (0xffb54200)
> "server-process-filter" (0xffb54458)
> "sit-for" (0xffb56548)
> "server-return-error" (0xffb56710)
> "server-process-filter" (0xffb56968)
> "sit-for" (0xffb58a58)

Does the patch below help?

diff --git a/lisp/server.el b/lisp/server.el
index b650532..e89a205 100644
--- a/lisp/server.el
+++ b/lisp/server.el
@@ -1159,7 +1159,7 @@ server-process-filter
       ;; it, in case the error written by emacsclient to stderr is not
       ;; visible for some reason.
       (message "Authentication failed")
-      (sit-for 2)
+      (sit-for 2 t)
       (server-send-string
        proc (concat "-error " (server-quote-arg "Authentication failed")))
       (unless (eq system-type 'windows-nt)
@@ -1169,7 +1169,7 @@ server-process-filter
            (delete-terminal terminal))))
       ;; Before calling `delete-process', give emacsclient time to
       ;; receive the error string and shut down on its own.
-      (sit-for 1)
+      (sit-for 1 t)
       (delete-process proc)
       ;; We return immediately.
       (cl-return-from server-process-filter)))
@@ -1508,7 +1508,7 @@ server-return-error
     ;; it, in case the error written by emacsclient to stderr is not
     ;; visible for some reason.
     (message (error-message-string err))
-    (sit-for 2)
+    (sit-for 2 t)
     (server-send-string
      proc (concat "-error " (server-quote-arg
                              (error-message-string err))))
@@ -1520,7 +1520,7 @@ server-return-error
          (delete-terminal terminal))))
     ;; Before calling `delete-process', give emacsclient time to
     ;; receive the error string and shut down on its own.
-    (sit-for 5)
+    (sit-for 5 t)
     (delete-process proc)))
 
 (defun server-goto-line-column (line-col)