bug#70901: 30.0.50; Tramp doesn't use ControlMaster even with (setq tramp-use-connection-share nil)

[Dmitry Gutov]

Hi Michael,

On 18/05/2024 14:19, Michael Albinus wrote:
> Dmitry Gutov <dmitry@gutov.dev> writes:

> > Perhaps it'd make sense to adjust the logging so that the first
> > "...done" is printed right after the connection is established.
>
> That is already the case. Tramp uses a (slightly modified version) of
> the progress reporter. You'll see two invocations of it, "Opening
> connection ..." and "Waiting for prompts ...". They are cascaded. When
> the second, inner progress reporter finishes, ssh has returned the prompt.

That's really what I meant: when looking at the echo area, I'm given the 
impression that the connection itself takes longer than it really does - 
because the "outer" phase said "Opening connection", and it finishes 
much later than the opening of the connection takes.

> --8<---------------cut here---------------start------------->8---
> 13:01:30.750374 tramp-maybe-open-connection (3) # Opening connection nil for 
> gandalf using ssh...
> 13:01:30.794366 tramp-send-command (6) # exec ssh -o ControlMaster=auto -o 
> ControlPath=/home/albinus/.cache/emacs/tramp.%C -o ControlPersist=no -e none 
> gandalf || exit
> 13:01:30.794769 tramp-process-actions (3) # Waiting for prompts from remote 
> shell...
> 13:01:32.633372 tramp-process-actions (6) #
> Last login: Sat May 18 13:01:31 2024 from 2002:6443:eb5:0:f832:242f:9e14:df3d
> [albinus@gandalf ~]$
> 13:01:32.633453 tramp-process-actions (3) # Waiting for prompts from remote 
> shell...done
> 13:01:35.830072 tramp-maybe-open-connection (3) # Opening connection nil for 
> gandalf using ssh...done
> --8<---------------cut here---------------end--------------->8---
>
> One modification of Tramp is, that in case of cascaded progress reportes
> only the outer one is visible in the echo area.

That by itself seems reasonable - chattiness in the echo area can be a 
problem by itself.