[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#69584: 29.2.50; project-find-functions should have access to maybe-p
From: |
Spencer Baugh |
Subject: |
bug#69584: 29.2.50; project-find-functions should have access to maybe-prompt |
Date: |
Thu, 04 Apr 2024 10:29:48 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Dmitry Gutov <dmitry@gutov.dev> writes:
> On 22/03/2024 15:05, Spencer Baugh wrote:
>>> If this change will be enough to cover your scenario, let's go ahead
>>> and add the 'non-essential' binding. It does seem to make sense for
>>> Tramp, at least.
>> Yes, that completely covers my scenario. (Putting aside whether my
>> scenario is a good idea :) )
>> So I would be happy with that.
>
> Now pushed to master as commit 1552f8345d8.
Ah, I think this is not quite right, should be:
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 1da03c7b60e..3cd6dafb409 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -229,8 +229,8 @@ project-current
of the project instance object."
(unless directory (setq directory (or project-current-directory-override
default-directory)))
- (let ((pr (project--find-in-directory directory))
- (non-essential (not maybe-prompt)))
+ (let* ((non-essential (not maybe-prompt))
+ (pr (project--find-in-directory directory)))
(cond
(pr)
((unless project-current-directory-override