bug#63539: 29.0.90; TRAMP fails to detect shell prompts containing ]

[Michael Albinus]

Spencer Baugh <sbaugh@janestreet.com> writes:

Hi Spence,

>> Oh no! There are much more escape sequences but for coloring. We would
>> open a can of worms if we start to handle them in Tramp regexps.
>
> Wait, but we already have exactly this kind of regexp for escape
> characters in tramp-shell-prompt-regexp.  That's where I copied
> this regexp from.

I know. But there are problems with it:

- It isn't sufficient. We have at least the zle Problem with a remote
  zsh, which is also an escape sequence (I believe). So the regexp would
  need to be extended, which isn't the way we should go, I believe.

- We cannot change shell-prompt-pattern just for Tramp. As said, it is
  used also at other places in Emacs and in external packages, and I
  don't know whether there would be collateral damages.

That's why I've proposed the alternative, filtering out escape
sequences. Using existing functions from specialized packages.

Best regards, Michael.