[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62413: 29.0.60; [PATCH] save-place-mode cannot restore saved positio
From: |
Liu Hui |
Subject: |
bug#62413: 29.0.60; [PATCH] save-place-mode cannot restore saved position |
Date: |
Tue, 4 Apr 2023 09:37:26 +0800 |
Ruijie Yu <ruijie@netyu.xyz> 于2023年4月3日周一 11:06写道:
> Two minor comments below.
>
> > @@ -90,8 +92,32 @@ save-place-forget-unreadable-files
> > (defcustom save-place-abbreviate-file-names nil
> > [...]
> > + :set (lambda (sym val)
> > + (set-default sym val)
> > + (let ((fun (if val 'abbreviate-file-name 'expand-file-name)))
>
> I believe function quotes "#'" are preferred over simple quotes "'" when
> dealing with functions.
OK
> > @@ -214,7 +241,11 @@ save-place-to-alist
> > ((and (derived-mode-p 'dired-mode) directory)
> > (let ((filename (dired-get-filename nil t)))
> > (if filename
> > - `((dired-filename . ,filename))
> > + (list
> > + (cons 'dired-filename
> > + (if
> > save-place-abbreviate-file-names
> > + (abbreviate-file-name
> > filename)
> > + filename)))
>
> It seems that you rewrote the quote-backquote thing with regular
> list-cons construct -- no comments on that. I noticed that here, and in
> a few other places, you are reusing the exact `if' construct multiple
> times. Does that warrant defining a helper function?
I feel such a function is too short.
> Also, while I was about to send the mail, regarding the docstring of
> `save-place-abbreviate-file-names', instead of letting the user enable
> `save-place-mode', would it be better if you directly call facilities in
> saveplace to load `save-place-alist' from file system, within your :set
> function?
Thanks for the suggestion. I have added `save-place-load-alist-from-file'
to the :set function in the new patch.
0001-Restore-positions-reliably-for-abbreviated-file-name.patch
Description: Text Data